Refactor backgrounds tasks for better visibility #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, tasks were managed either via ephemeral messages in actor or via a tasks table
After this change, all tasks are managed via a central tasks table with actors running in parallel (one for each task type). Error reporting is fully centralized and retry is built in.
We also can now remove the custom migrations table used to log errors for versions of applications that failed to upgrade to the latest service spec (all migrations have completed, in future we can monitor via these tasks)
We also introduce the groundwork for periodically checking invariants to increase quality of monitoring. Future work will wire up the invariants.