fix: check join_thread attribute in queue when cleaning mp exec

aphp · Nov 20, 2024 · 3dd3072 · 3dd3072
1 parent 1ffa7c6
commit 3dd3072
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,11 @@
 # Changelog
 
+# Unreleased
+
+### Fixed
+
+- Fix `join_thread` missing attribute in `SimpleQueue` when cleaning a multiprocessing executor
+
 ## v0.14.0 (2024-11-14)
 
 ### Added

diff --git a/edsnlp/processing/multiprocessing.py b/edsnlp/processing/multiprocessing.py
@@ -452,7 +452,8 @@ def run(self):
             for stage in self.stages_to_run:
                 for name, queue in self.consumer_queues(stage):
                     queue.close()
-                    queue.join_thread()
+                    if hasattr(queue, "join_thread"):
+                        queue.join_thread()
 
             self.final_barrier.wait()
 
@@ -1182,7 +1183,8 @@ def feed_queue(self, queue, items):
                 if q is queue:
                     queue.put(STOP)
             queue.close()
-            queue.join_thread()
+            if hasattr(queue, "join_thread"):
+                queue.join_thread()
 
     def dequeue_notifications(self):
         while True: