allows naming - move improve performance file

[svittoz]

Description

In improve_performance function :

• Allows app_name parameter so that user can distinguish two kernels from the same project.
• Improve_performance function definition moved in io folder.

Checklist

• If this PR is a bug fix, the bug is documented in the test suite.
• Changes were documented in the changelog (pending section).
• If necessary, changes were made to the documentation (eg new pipeline).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e29cbd) 83.74% compared to head (74a4576) 83.22%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   83.74%   83.22%   -0.53%     
==========================================
  Files          82       83       +1     
  Lines        2492     2492              
==========================================
- Hits         2087     2074      -13     
- Misses        405      418      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheooJ]

Hi Simon !

• "Allows app_name parameter so that user can distinguish two kernels from the same project." -> this is really useful !
• "Lazy operations does not seem to work" which operation are you referring to ? Note that some ks operations are rewritten, making them eager:

  eds-scikit/eds_scikit/utils/custom_implem/custom_implem.py

  Line 68 in 053a943

  def cache(cls, df, backend=None):

Also, I think improve_performance should be accessible from eds_scikit, but shouldn't be written in __init__.py. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by setting from path.to.file import improve_performance in the __init__.py

[svittoz]

Hi Simon !

• "Allows app_name parameter so that user can distinguish two kernels from the same project." -> this is really useful !
• "Lazy operations does not seem to work" which operation are you referring to ? Note that some ks operations are rewritten, making them eager:

  eds-scikit/eds_scikit/utils/custom_implem/custom_implem.py

  Line 68 in 053a943

  def cache(cls, df, backend=None):

Also, I think improve_performance should be accessible from eds_scikit, but shouldn't be written in __init__.py. Writing functions there makes it hard to follow the codebase. I suggest writing it elsewhere and making it accessible by setting from path.to.file import improve_performance in the __init__.py

I moved improve_performance into io folder and import it in the init as you suggested.

[TheooJ]

Added some comments, let me know what you think :)

[TheooJ]

Looks good to me !
Last comment that's a bit nitpick : should we rename the new improve_performance.py file ?

[svittoz]

Moving improve_performance out of init and adding app_name parameter.

[svittoz]

Adding app_name parameter and moving improve_performance out of init.py

[svittoz]

Addin app_name parameter and moving improve_performance.

[Thomzoy]

Ok no problem !