Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch pyarrow.open_stream to support pyarrow>0.17 #52

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

percevalw
Copy link
Member

Description

Support pyarrow > 0.17.0

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (176fb15) 83.82% compared to head (658ad10) 83.43%.
Report is 1 commits behind head on main.

❗ Current head 658ad10 differs from pull request most recent head 31ba5f2. Consider uploading reports for the commit 31ba5f2 to get more accurate results

Files Patch % Lines
eds_scikit/__init__.py 80.00% 2 Missing ⚠️
eds_scikit/datasets/synthetic/biology.py 60.00% 2 Missing ⚠️
eds_scikit/io/hive.py 50.00% 2 Missing ⚠️
eds_scikit/utils/checks.py 50.00% 2 Missing ⚠️
eds_scikit/utils/custom_implem/custom_implem.py 50.00% 2 Missing ⚠️
eds_scikit/utils/framework.py 50.00% 2 Missing ⚠️
eds_scikit/utils/typing.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   83.82%   83.43%   -0.39%     
==========================================
  Files          82       82              
  Lines        2492     2518      +26     
==========================================
+ Hits         2089     2101      +12     
- Misses        403      417      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw requested review from Thomzoy and svittoz December 7, 2023 08:52
Copy link
Collaborator

@svittoz svittoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution !

@Thomzoy Thomzoy merged commit e7320c7 into main Mar 21, 2024
4 of 5 checks passed
@svittoz svittoz mentioned this pull request Apr 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants