Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioclean edit #51

Merged
merged 89 commits into from
Mar 19, 2024
Merged

Bioclean edit #51

merged 89 commits into from
Mar 19, 2024

Conversation

svittoz
Copy link
Collaborator

@svittoz svittoz commented Nov 30, 2023

Description

This PR intends to fix some issues related to bioclean module and to make it easier to use while keeping core functionalities.

  • Make the biology pipeline more direct (prepare_measurement_table and plot_biology_summary are now independent functions)
  • Prepare_measurement_table is inspired from EDS-Teva prepare_df module.
  • Units configuration is no longer set with a pre-defined file but in the ConceptSet definition
  • Docstring for some functions
  • Updated and validated concept sets

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@Thomzoy
Copy link
Collaborator

Thomzoy commented Mar 5, 2024

TMP

It's a very nice PR ! I'm writing down some temporary remarks regarding the doc here:

  • Try adding the blacken-docs to the precommit ? For better visibility of code snippets in the documentation
  • [Fixed] Problem with tables rendering when clicking to full page
  • Uniformize name of cards VS name in the navigation menu
  • Regarding naming, do we keep prepare_measurement for the main function name ?

@Thomzoy Thomzoy self-requested a review March 19, 2024 12:53
Copy link
Collaborator

@Thomzoy Thomzoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work, we can merge !

@svittoz svittoz merged commit d85ef2a into main Mar 19, 2024
7 checks passed
@svittoz svittoz mentioned this pull request Apr 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants