Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dates_normalizer pipe to parse the ml dates value & format #11

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

percevalw
Copy link
Member

Description

To address #10. This is closely related to aphp/edsnlp#174, but here we assume that the date has been correctly extracted, whereas eds.dates has to find a balance between precision and recall, limiting the variety of date formats it supports.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation.

@percevalw percevalw force-pushed the dates_normalizer branch 5 times, most recently from d722d05 to 2ce4f06 Compare January 12, 2024 08:46
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7247384) 99.82% compared to head (c672363) 99.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   99.82%   99.86%   +0.04%     
==========================================
  Files          15       17       +2     
  Lines         579      761     +182     
==========================================
+ Hits          578      760     +182     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw merged commit 5f6bf3d into main Jan 22, 2024
10 checks passed
@percevalw percevalw deleted the dates_normalizer branch January 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant