Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hack for creating clusters #87

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Dec 4, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (aea081b) 42.94% compared to head (4b7a341) 42.98%.

❗ Current head 4b7a341 differs from pull request most recent head b2c28fa. Consider uploading reports for the commit b2c28fa to get more accurate results

Files Patch % Lines
pkg/cmd/cluster/create.go 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   42.94%   42.98%   +0.03%     
==========================================
  Files         223      223              
  Lines       28609    28597      -12     
==========================================
+ Hits        12287    12291       +4     
+ Misses      14798    14786      -12     
+ Partials     1524     1520       -4     
Flag Coverage Δ
unittests 42.98% <92.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 639d217 into main Dec 4, 2023
5 checks passed
@wangyelei wangyelei deleted the bugfix/configurable_vct branch December 4, 2023 02:14
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants