Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kbcli cluster connect use root credential #68

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

shanshanying
Copy link
Contributor

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 22, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (e4302b6) 43.10% compared to head (bb75582) 43.10%.
Report is 1 commits behind head on main.

❗ Current head bb75582 differs from pull request most recent head 4235295. Consider uploading reports for the commit 4235295 to get more accurate results

Files Patch % Lines
pkg/cmd/cluster/connect.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   43.10%   43.10%   -0.01%     
==========================================
  Files         222      222              
  Lines       28360    28366       +6     
==========================================
+ Hits        12225    12227       +2     
- Misses      14625    14629       +4     
  Partials     1510     1510              
Flag Coverage Δ
unittests 43.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanshanying shanshanying merged commit d07de61 into main Nov 22, 2023
5 checks passed
@shanshanying shanshanying deleted the bugfix/kbcli-connect-use-root-credential branch November 22, 2023 15:44
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kbcli failed to connect cluster
3 participants