Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cluster connect to replica whose pod role label is set as primary #65

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@xuriwuyun xuriwuyun added this to the Release 0.8.0 milestone Nov 22, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 22, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (756333e) 43.12% compared to head (33967fc) 43.10%.

Files Patch % Lines
pkg/cluster/helper.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   43.12%   43.10%   -0.03%     
==========================================
  Files         222      222              
  Lines       28351    28360       +9     
==========================================
- Hits        12227    12225       -2     
- Misses      14614    14624      +10     
- Partials     1510     1511       +1     
Flag Coverage Δ
unittests 43.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuriwuyun xuriwuyun linked an issue Nov 22, 2023 that may be closed by this pull request
@ldming ldming changed the title cluster connect to replica whose pod role label is set as primary chore: cluster connect to replica whose pod role label is set as primary Nov 22, 2023
@xuriwuyun xuriwuyun merged commit e4302b6 into main Nov 22, 2023
18 of 19 checks passed
@xuriwuyun xuriwuyun deleted the bugfix/connect_primary_replica branch November 22, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]kbcli cluster connect cluster failed
4 participants