Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix kbcli addon index update always latest #59

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: fix kbcli addon index update always latest #59

merged 1 commit into from
Nov 21, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Nov 20, 2023

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 20, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a623b61) 42.88% compared to head (7d16af2) 42.85%.

Files Patch % Lines
pkg/util/git.go 0.00% 22 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   42.88%   42.85%   -0.03%     
==========================================
  Files         222      222              
  Lines       28333    28351      +18     
==========================================
  Hits        12150    12150              
- Misses      14689    14707      +18     
  Partials     1494     1494
Flag Coverage Δ
unittests 42.85% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1aal 1aal merged commit 756333e into main Nov 21, 2023
12 checks passed
@1aal 1aal deleted the bugfix/addon-index-update branch November 21, 2023 02:35
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

[BUG] addon index update failed
3 participants
@1aal @codecov-commenter @ldming