Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix check kb upgrade release status in 0.9 #493

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

yipeng1030
Copy link
Contributor

move checking upgrade release status from cmd/kubeblocks/upgrade to helm/upgrade() and improve UT.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.77%. Comparing base (ade33b4) to head (eaa7d1b).

Files with missing lines Patch % Lines
pkg/util/helm/helm.go 71.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-0.9     #493   +/-   ##
============================================
  Coverage        42.77%   42.77%           
============================================
  Files              183      183           
  Lines            26064    26073    +9     
============================================
+ Hits             11149    11153    +4     
- Misses           13596    13600    +4     
- Partials          1319     1320    +1     
Flag Coverage Δ
unittests 42.77% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yipeng1030 yipeng1030 merged commit 1533d82 into release-0.9 Nov 21, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the bugfix/fix_upgrade_0.9 branch November 21, 2024 03:51
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants