Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cluster create support specify schedulingpolicy #483

Merged

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Nov 4, 2024

what's changed?

cluster create support translate flags like PodAntiAffinity、TopologyKeys、NodeLabels、TolerationsRaw and Tenancy to SchedulingPolicy in cluster.componentSpecs.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 18.69919% with 100 lines in your changes missing coverage. Please review.

Project coverage is 41.94%. Comparing base (2e2279f) to head (0a65def).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/util.go 0.00% 79 Missing ⚠️
pkg/cmd/cluster/create_subcmds.go 52.27% 14 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   42.02%   41.94%   -0.09%     
==========================================
  Files         167      167              
  Lines       22984    23101     +117     
==========================================
+ Hits         9660     9689      +29     
- Misses      12210    12293      +83     
- Partials     1114     1119       +5     
Flag Coverage Δ
unittests 41.94% <18.69%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 force-pushed the feature/create_schedulingpolicy_when_create_cluster branch from b59bd16 to 0a65def Compare November 8, 2024 06:08
@yipeng1030 yipeng1030 merged commit 509f77e into main Nov 8, 2024
15 checks passed
@yipeng1030 yipeng1030 deleted the feature/create_schedulingpolicy_when_create_cluster branch November 8, 2024 16:28
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants