Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use opsrequst to achieve backup and restore #45

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

fengluodb
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 16, 2023
@fengluodb fengluodb linked an issue Nov 16, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a623b61) 42.88% compared to head (960c3df) 42.88%.

Files Patch % Lines
pkg/cmd/cluster/dataprotection.go 83.33% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   42.88%   42.88%           
=======================================
  Files         222      222           
  Lines       28333    28281   -52     
=======================================
- Hits        12150    12129   -21     
+ Misses      14689    14668   -21     
+ Partials     1494     1484   -10     
Flag Coverage Δ
unittests 42.88% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming
Copy link
Collaborator

ldming commented Nov 18, 2023

Does the output of the command kbcli cluster backup need to be adjusted? It will output the command prompt for viewing backups.

@fengluodb
Copy link
Collaborator Author

Does the output of the command kbcli cluster backup need to be adjusted? It will output the command prompt for viewing backups.

I think user should only concern the result, such as the backup name and cluster name. They don't need know the process.

@ldming
Copy link
Collaborator

ldming commented Nov 20, 2023

resolve the conflicts

@wangyelei
Copy link
Contributor

is it necessary to use opsRequest for backup and restore? This step will add an additional opsRequest object

@fengluodb fengluodb force-pushed the feature/backup-restore-use-opsrequest branch from 7475ba5 to 960c3df Compare November 20, 2023 02:37
@fengluodb
Copy link
Collaborator Author

is it necessary to use opsRequest for backup and restore? This step will add an additional opsRequest object

If backup and restore logic have changed, we don't need to change the code in kubeblock and kbcli meanwhile.

@ldming
Copy link
Collaborator

ldming commented Nov 21, 2023

is it necessary to use opsRequest for backup and restore? This step will add an additional opsRequest object

If backup and restore logic have changed, we don't need to change the code in kubeblock and kbcli meanwhile.

Better to set a default TTL seconds for opsRequest, avoid the opsRequest remained.

@fengluodb
Copy link
Collaborator Author

is it necessary to use opsRequest for backup and restore? This step will add an additional opsRequest object

If backup and restore logic have changed, we don't need to change the code in kubeblock and kbcli meanwhile.

Better to set a default TTL seconds for opsRequest, avoid the opsRequest remained.

ok, I have set ttlSecondsAfterSucceed 30s in opsrequest_template.cue.

@fengluodb fengluodb merged commit e4ed84b into main Nov 22, 2023
17 checks passed
@fengluodb fengluodb deleted the feature/backup-restore-use-opsrequest branch November 22, 2023 13:13
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] achieve backup and restore using opsrequest
4 participants