Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs dir to store kbcli log #37

Merged
merged 2 commits into from
Nov 14, 2023
Merged

chore: add logs dir to store kbcli log #37

merged 2 commits into from
Nov 14, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Nov 14, 2023

ll ~/.kbcli/logs
total 8
-rw-r--r--  1 ldm  staff   786B Nov 14 10:06 kbcli-2023-11-14.log

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 14, 2023
@ldming ldming requested a review from 1aal November 14, 2023 02:16
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (068e85a) 43.09% compared to head (42f0e34) 43.08%.

Files Patch % Lines
pkg/util/util.go 0.00% 11 Missing ⚠️
pkg/util/log.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   43.09%   43.08%   -0.02%     
==========================================
  Files         221      221              
  Lines       28060    28071      +11     
==========================================
  Hits        12093    12093              
- Misses      14481    14492      +11     
  Partials     1486     1486              
Flag Coverage Δ
unittests 43.08% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1aal 1aal merged commit ab2f4e5 into main Nov 14, 2023
12 checks passed
@1aal 1aal deleted the feature/add-log-dir branch November 14, 2023 05:55
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 14, 2023
@ldming ldming restored the feature/add-log-dir branch November 15, 2023 01:05
@ldming ldming deleted the feature/add-log-dir branch November 15, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants