fix: check existence of backuprepo before creating a backup #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnolong
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf and
1aal
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 42.80% 42.81% +0.01%
==========================================
Files 213 213
Lines 29109 29134 +25
==========================================
+ Hits 12459 12473 +14
- Misses 15109 15116 +7
- Partials 1541 1545 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wangyelei
reviewed
May 9, 2024
| existDefaultBackupRepo = true | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
checks if existing more than one backupRepo, only need one default backupRepo
ldming
approved these changes
May 9, 2024
gnolong
deleted the
support/check-existence-of-backuprepo-before-creating-a-backup
branch
gnolong
restored the
support/check-existence-of-backuprepo-before-creating-a-backup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check existence of backuprepo before creating a backup