Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not set default image registry #114

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix: do not set default image registry #114

merged 3 commits into from
Dec 15, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Dec 15, 2023

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2b2ac31) 43.00% compared to head (024dd68) 43.00%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/cmd/addon/addon.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   43.00%   43.00%           
=======================================
  Files         228      228           
  Lines       29158    29158           
=======================================
  Hits        12539    12539           
  Misses      15080    15080           
  Partials     1539     1539
Flag Coverage Δ
unittests 43.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1aal 1aal marked this pull request as ready for review December 15, 2023 05:03
@ldming ldming changed the title fix: Filter the addon image regisry configurations by provider label. fix: do not set default image registry Dec 15, 2023
@1aal 1aal merged commit 5df7e8a into main Dec 15, 2023
12 checks passed
@1aal 1aal deleted the bugfix/fix-three-patry-addon-registry branch December 15, 2023 05:40
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 15, 2023
1aal added a commit that referenced this pull request Dec 15, 2023
@1aal
fix: do not set default image registry (#114)
73b949b 
(cherry picked from commit 5df7e8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

[BUG] The kbcli addon registry config should check whether the addon is managed by Apecloud.
3 participants
@1aal @codecov-commenter @ldming