Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apiserver address to viper #111

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Conversation

lynnleelhl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 14, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 14, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 14, 2023
@lynnleelhl
Copy link
Contributor Author

/approve

@codecov-commenter
Copy link

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (66412ca) 43.03% compared to head (86c5f4a) 43.01%.

Files Patch % Lines
pkg/cmd/context/cloud_context.go 0.00% 17 Missing ⚠️
pkg/cmd/context/context.go 36.36% 7 Missing ⚠️
pkg/cmd/cli.go 0.00% 3 Missing ⚠️
pkg/cmd/organization/organization.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   43.03%   43.01%   -0.03%     
==========================================
  Files         228      228              
  Lines       29154    29158       +4     
==========================================
- Hits        12546    12541       -5     
- Misses      15069    15079      +10     
+ Partials     1539     1538       -1     
Flag Coverage Δ
unittests 43.01% <14.70%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnleelhl lynnleelhl merged commit 2b2ac31 into main Dec 14, 2023
12 checks passed
@lynnleelhl lynnleelhl deleted the support/apiserver-url branch December 14, 2023 10:33
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants