fix: using iterator as value of pointer

apecloud · Oct 11, 2023 · 59cc19f · 59cc19f
1 parent 0d269ed
commit 59cc19f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/controllers/monitor/reconcile/oteld.go b/controllers/monitor/reconcile/oteld.go
@@ -60,15 +60,17 @@ func OTeld(reqCtx monitortype.ReconcileCtx, params monitortype.OTeldParams) (err
 		return err
 	}
 	instanceMap, err := buildOteldInstance(datasources, oteldTemplates)
-	reqCtx.SetOteldInstanceMap(instanceMap)
 
-	for _, template := range oteldTemplates.Items {
-		instance := reqCtx.GetOteldInstance(template.Spec.Mode)
+	for i := 0; i < len(oteldTemplates.Items); i++ {
+		template := oteldTemplates.Items[i]
+		instance := instanceMap[template.Spec.Mode]
 		if instance == nil {
 			continue
 		}
 		instance.OteldTemplate = &template
 	}
+
+	reqCtx.SetOteldInstanceMap(instanceMap)
 	if err != nil {
 		return err
 	}