Skip to content

Commit

Permalink
Merge branch 'main' into feature/add-log-dir
Browse files Browse the repository at this point in the history
  • Loading branch information
ldming committed Nov 14, 2023
2 parents 98be079 + 068e85a commit 42f0e34
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @nayutah @ldming @heng4fun @free6om @wangyelei @leon-inf
* @nayutah @ldming @heng4fun @free6om @wangyelei @leon-inf @1aal
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Bug report
about: Create a report to help us improve
title: "[BUG]"
labels: kind/bug
assignees: nayutah
assignees: ldming

---

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Feature request
about: Suggest a user related feature for this project
title: "[Features]"
labels: area/user-interaction, documentation, kind/feature
assignees: nayutah
assignees: ldming

---

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/improvement-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Improvement request
about: Suggest an improvement idea for this project
title: "[Improvement]"
labels: kind/enhancement
assignees: nayutah
assignees: ldming

---

Expand Down
2 changes: 1 addition & 1 deletion pkg/action/edit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import (
"github.com/apecloud/kbcli/pkg/types"
)

var _ = Describe("List", func() {
var _ = Describe("Edit", func() {
var (
streams genericiooptions.IOStreams
tf *cmdtesting.TestFactory
Expand Down
6 changes: 3 additions & 3 deletions pkg/action/patch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ var _ = Describe("Patch", func() {

It("run", func() {
cmd := &cobra.Command{}
o := NewPatchOptions(tf, streams, types.ClusterGVR())
o.Names = []string{"c1"}
o := NewPatchOptions(tf, streams, types.CRDGVR())
o.Names = []string{"test"}
o.AddFlags(cmd)

o.Patch = "{terminationPolicy: Delete}"
// The resource "CRD" expect not found in mock K8s
Expect(o.Run(cmd)).Should(HaveOccurred())
})
})
2 changes: 1 addition & 1 deletion pkg/action/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ import (

func TestCreate(t *testing.T) {
RegisterFailHandler(Fail)
RunSpecs(t, "Create Suite")
RunSpecs(t, "Action Suite")
}

0 comments on commit 42f0e34

Please sign in to comment.