Add PooledBinary Class #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrQuansy
force-pushed
the
blob_allocator
branch
from
45b5dd4
to
9ec386b
Compare
java/common/src/main/java/org/apache/tsfile/utils/PooledBinary.java
Outdated
Show resolved
Hide resolved
| if (length != binary.getLength()) { | ||
| return false; | ||
| } | ||
| for (int i = 0; i < length; i++) { |
There was a problem hiding this comment.
Please use this API
Because it's vectorized.
There was a problem hiding this comment.
not compatible with jdk8 , please ignore this comment
java/common/src/main/java/org/apache/tsfile/utils/PooledBinary.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add PooledBinary class for Binary object allocation optimization.
This PR introduces a new PooledBinary class designed for binary object pooling at the application layer. It aims to improve allocation performance and reduce GC overhead by enabling binary object reuse.
Details
The PooledBinary class is similar to the existing Binary class but with additional features to support object pooling:
Next Steps
This is the first step in a series of planned changes. Future PRs will modify specific Binary usages to PooledBinary in the codebase.