[TRAFODION-2920]Add hibernate dialect support. #1407
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| @@ -0,0 +1,30 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
License head is required for every file.
|
Can one of the admins verify this patch? |
xlloveyun
changed the title
|
+1 Good! |
|
I have a concern here. Maven POM is set to pull in the hibernate-core dependency, which appears to be licensed under LGPL. That is not something we can bundle. |
xlloveyun
force-pushed
the
master
branch
2 times, most recently
from
6fc38a4
to
8d907de
Compare
|
@svarnau, did the latest change answer your concern? |
|
No, my concern is not addressed. There is still license issue with the hibernate dependency, as far as I can see. |
|
I don't familiar with the license issue. Is there any document saying we can not use? As i know if we want to make any changes on the source code, it should involve license issue. We also did use Python which is GPL license in DCS pom.xml. What do you think or any body we could ask? |
|
Looked a pom.xml in Apache Spark and some of the dependencies are not from Apache. So I think it might be ok( correct me if i am wrong). |
|
http://apache.org/legal/resolved.html#category-x The DCS dependency you mention is jython-standalone, which has a different license, and is regferenced in our license file(s). |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
No description provided.