Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEZ-4558] Update build setup maven version and enforcer minimum to correct minimum #350

Merged
merged 1 commit into from
May 3, 2024

Conversation

jteagles
Copy link
Contributor

@jteagles jteagles commented May 2, 2024

No description provided.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 27m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 17m 47s master passed
+1 💚 compile 2m 27s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 compile 2m 13s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javadoc 1m 46s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 10s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 💚 mvninstall 4m 31s the patch passed
+1 💚 compile 2m 28s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javac 2m 28s the patch passed
+1 💚 compile 2m 14s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javac 2m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 14s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 10s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 ❌ unit 49m 19s root in the patch failed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
115m 28s
Reason Tests
Failed junit tests tez.test.TestDAGRecovery
tez.test.TestAMRecovery
tez.test.TestRecovery
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/1/artifact/out/Dockerfile
GITHUB PR #350
JIRA Issue TEZ-4558
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux b3e3ee36d49f 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / a77f8ef
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/1/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/1/testReport/
Max. process+thread count 2090 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/1/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test failure aren't related, Have identified the cause, will get them fixed separately

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded maven 3.1.1 and tried to build the project but got the following error.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) on project tez-runtime-library: Execution process-resource-bundles of goal org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process failed: Failed to resolve dependencies for one or more projects in the reactor. Reason: Unable to get dependency information for io.netty:netty-buffer:jar:4.1.60.Final: Failed to retrieve POM for io.netty:netty-buffer:jar:4.1.60.Final: Could not transfer artifact io.netty:netty-buffer:pom:4.1.60.Final from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/io/netty/netty-buffer/4.1.60.Final/netty-buffer-4.1.60.Final.pom. Return code is: 501, ReasonPhrase: HTTPS Required.
[ERROR] io.netty:netty-buffer:jar:4.1.60.Final
[ERROR] 
[ERROR] from the specified remote repositories:
[ERROR] apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots, releases=true, snapshots=true),
[ERROR] apache.snapshots (https://repository.apache.org/snapshots, releases=false, snapshots=true),
[ERROR] central (http://repo.maven.apache.org/maven2, releases=true, snapshots=false)
[ERROR] Path to dependency:
[ERROR] 1) org.apache.tez:tez-runtime-library:jar:0.10.4-SNAPSHOT
[ERROR] 2) org.asynchttpclient:async-http-client:jar:2.12.3
[ERROR] 3) org.asynchttpclient:async-http-client-netty-utils:jar:2.12.3
[ERROR] -> [Help 1]

Is it really possible to build the project with the specified version?

mvn --version
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 17:22:22+0200)
Maven home: /home/...
Java version: 1.8.0_261, vendor: Oracle Corporation
Java home: /opt/jdks/jdk1.8.0_261/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-177-generic", arch: "amd64", family: "unix"

@jteagles
Copy link
Contributor Author

jteagles commented May 3, 2024

@zabetak , @ayushtkn
Plugin API compatibility requires maven 3.6.3 or higher according to the official documentation
https://maven.apache.org/docs/history.html
How do we feel about setting this as the minimum?
Otherwise we should consider 3.8.8 as the required minimum for building

@ayushtkn
Copy link
Member

ayushtkn commented May 3, 2024

If everything works from 3.6.3 then it should be good

@jteagles
Copy link
Contributor Author

jteagles commented May 3, 2024

@ayushtkn @zabetak , bumped minimum to 3.6.3. Rebuilt with an empty m2 cache to make sure all https dependencies will go through

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 17m 31s master passed
+1 💚 compile 2m 27s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 compile 2m 15s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javadoc 1m 46s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 10s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 💚 mvninstall 4m 32s the patch passed
+1 💚 compile 2m 28s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javac 2m 28s the patch passed
+1 💚 compile 2m 13s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 💚 javac 2m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 14s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 💚 javadoc 1m 10s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 ❌ unit 48m 6s root in the patch failed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
87m 27s
Reason Tests
Failed junit tests tez.test.TestDAGRecovery
tez.test.TestAMRecovery
tez.test.TestRecovery
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/2/artifact/out/Dockerfile
GITHUB PR #350
JIRA Issue TEZ-4558
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux fcdf771d9216 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / a77f8ef
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/2/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/2/testReport/
Max. process+thread count 1270 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-350/2/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteagles jteagles merged commit 906059a into apache:master May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants