-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4319. Add explicit dependency on snappy-java to tez-api. #137
Conversation
💔 -1 overall
This message was automatically generated. |
pom.xml
Outdated
@@ -65,6 +65,7 @@ | |||
<slf4j.version>1.7.30</slf4j.version> | |||
<protobuf.version>2.5.0</protobuf.version> | |||
<roaringbitmap.version>0.7.45</roaringbitmap.version> | |||
<snappy-java.version>1.1.8.4</snappy-java.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iwasakims If you have a use case, and if you feel this would help, we can bump it to 1.1.10.4 like in HADOOP-18912 to be in sync with Hadoop & merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushtkn I rebased the patch and updated the version of snappy-java. Thanks for the suggestion.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://issues.apache.org/jira/browse/TEZ-4319
Implicit dependency on snappy-java-1.0.5 was added by TEZ-4113. It causes error on platforms like aarch64 for which snappy binary is not provided.
Adding explicit dependency on recent snappy-java supporting aarch64 and ppc64le should address the issue.