Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (SIP-117): remove more sqlparse #31032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor (SIP-117): remove more sqlparse #31032

wants to merge 1 commit into from
+56 −122

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Nov 22, 2024 •
edited
Loading

SUMMARY

Some more work towards SIP-117

  • Remove is_readonly_query from DB engine specs, since all SQL parsing should now happen in SQLScript and SQLStatement.
  • Remove uses of ParsedQuery(sql).stripped(), since it's just a sql.strip().strip(";").

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Updated unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:backend Requires changing the backend label Nov 22, 2024
@michael-s-molina
Copy link
Member

Can you use refactor instead of chore for the PR title?

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Nov 22, 2024
@betodealmeida betodealmeida changed the title chore (SIP-117): remove more sqlparse refactor (SIP-117): remove more sqlparse Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change:backend Requires changing the backend preset-io review:checkpoint Last PR reviewed during the daily review standup size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betodealmeida @michael-s-molina