[SPARK-50395][SQL] Fix malformed URI syntax in Windows #48934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xupefei
changed the title
There was a problem hiding this comment.
If this is due to the OS-dependent bug, do you happen to know why this failure starts recently, @xupefei ?
Also, cc @HyukjinKwon
HyukjinKwon
approved these changes
Nov 24, 2024
|
I believe the cause was #48120. This is a followup for it. |
|
Let me merge this one in any event, and see if the CI is fixed |
|
Merged to master. |
|
Got it. Thank you, @xupefei and @HyukjinKwon . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes an issue that the Artifact Manager is using a malformed URI string for Class Dir in windows. The issue is caused by using a platform-specific
File.separatorinstead of/: Windows's file separator is\, which results in a wrong URI string:This failure is captured by the scheduled Windows build on
master, such as https://github.com/apache/spark/actions/runs/11958030827.To fix this issue we just make sure that the separator is always
/on all OSes.Why are the changes needed?
Fix a compilation failure in Windows.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested on my own fork with a modified Workflow that runs on PR: xupefei#1, https://github.com/xupefei/spark/actions/runs/11970330735/job/33372836765?pr=1
Was this patch authored or co-authored using generative AI tooling?
No.