-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][INFRA] Ensure that docs build successfully with SKIP_API=1 #44627
Changes from 6 commits
99fb443
1fa62c5
bd2e46e
4b87d5a
8042abc
93b6f21
f3ff166
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -761,6 +761,9 @@ jobs: | |
run: ./dev/lint-r | ||
- name: Run documentation build | ||
run: | | ||
# Build docs first with SKIP_API to ensure they are buildable without requiring any | ||
# language docs to be built beforehand. | ||
cd docs; SKIP_API=1 bundle exec jekyll build; cd .. | ||
if [ -f "./dev/is-changed.py" ]; then | ||
# Skip PySpark and SparkR docs while keeping Scala/Java/SQL docs | ||
pyspark_modules=`cd dev && python3.9 -c "import sparktestsupport.modules as m; print(','.join(m.name for m in m.all_modules if m.name.startswith('pyspark')))"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or wonder if we should set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, could you elaborate a little bit on this? How would this prevent yesterday's scenario? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually let's just merge this. 5 secs won't affect the elapsed time much anyway. |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but just to confirm this doesn't take a lot of time right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. This adds around 5 seconds to the "Run documentation build" step.