Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][SPARK-41100][INFRA] Upgrade Ubuntu to latest #38601

Closed
wants to merge 3 commits into from

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Nov 10, 2022

What changes were proposed in this pull request?

Upgrade ubuntu version on runners in github actions from 20.04 to latest

Why are the changes needed?

"Ubuntu 22.04 is now generally available on GitHub-hosted runners. To use it now, simply add runs-on: ubuntu-22.04 in your workflow file. Otherwise, our recommendation is to use ubuntu-latest, which currently utilizes Ubuntu 20.04 but will begin running on Ubuntu 22.04 in the near future."

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

@github-actions github-actions bot added the INFRA label Nov 10, 2022
@bjornjorgensen bjornjorgensen changed the title [WIP] Upgrade Ubuntu latest [SPARK-41100][WIP] Upgrade Ubuntu latest Nov 10, 2022
@bjornjorgensen bjornjorgensen changed the title [SPARK-41100][WIP] Upgrade Ubuntu latest [WIP][SPARK-41100] Upgrade Ubuntu latest Nov 10, 2022
@bjornjorgensen bjornjorgensen changed the title [WIP][SPARK-41100] Upgrade Ubuntu latest [WIP][SPARK-41100][INFRA] Upgrade Ubuntu to latest Nov 10, 2022
@bjornjorgensen bjornjorgensen changed the title [WIP][SPARK-41100][INFRA] Upgrade Ubuntu to latest [SPARK-41100][INFRA] Upgrade Ubuntu to latest Nov 10, 2022
@bjornjorgensen
Copy link
Contributor Author

@Yikun

@Yikun
Copy link
Member

Yikun commented Nov 10, 2022

I think we should upgrade to ubuntu-22.04 when github action ubuntu-latest point to 22.04, rather than use the ubuntu-latest directly, to reduce the potential impacts of OS upgrade breaking change.

You could try to use ubuntu-22.04 in this PR, once ubuntu-latest upgrade we can merge then.

@bjornjorgensen
Copy link
Contributor Author

gregrahn/tpcds-kit#57

@bjornjorgensen bjornjorgensen marked this pull request as draft November 10, 2022 21:06
@bjornjorgensen bjornjorgensen changed the title [SPARK-41100][INFRA] Upgrade Ubuntu to latest [WIP][SPARK-41100][INFRA] Upgrade Ubuntu to latest Nov 10, 2022
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@bjornjorgensen
Copy link
Contributor Author

@Yikun
GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04

@Yikun
Copy link
Member

Yikun commented Dec 2, 2022

Looks like only tpcds test has some impact, After tpcds bug fixed, we can switch then.

I think Ubuntu 20.04 will also have good supported before Apr 2025.

https://ubuntu.com/about/release-cycle

also cc @HyukjinKwon

@bjornjorgensen
Copy link
Contributor Author

Yes, I will close this PR for now.

@bjornjorgensen bjornjorgensen deleted the Ubuntu-latest branch December 21, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants