feature: add support for Pulsar #173
Conversation
|
Maybe I need some time, please hold for a while, thanks. AFAIK, We have Pulsar monitoring and agent plugins (Java is ready and Go are currently in progress) for Pulsar, skywalking-showcase needs to be added accordingly? I am willing to try. |
|
Showcase is fine, it can't hold all plugin examples there. |
|
Meanwhile, you should try and test service hierarchy for Pulsar, if you want. especially from virtual MQ to MQ server. |
Copy that, I want to try it. |
|
PTAL. |
| segments: | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: GET:/health |
There was a problem hiding this comment.
Please delete the GET:/health checker.
There was a problem hiding this comment.
I noticed that I have also retained this spans in other plugin's file, I'll delete it in future PR.
| - { key: mq.topic, value: not null } | ||
| - { key: mq.msg.id, value: not null } | ||
| - operationName: Pulsar/sw-topic-1/Consumer | ||
| parentSpanId: 0 |
There was a problem hiding this comment.
Why the consumer parent span id is 0(span GET:/execute), I think It should be Pulsar/sw-topic-1/Producer. Am I right?
There was a problem hiding this comment.
In the current test code, both consumer and producer are triggered by http.
| - { key: status_code, value: '200' } | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: Pulsar/sw-topic-2/Producer/Callback |
There was a problem hiding this comment.
When will we have the Callback span, It's a local span and not reference? Could you please add the screenshot about this plugin test? I'm not sure what's the real show like.
There was a problem hiding this comment.
Now as shown in the figure, when the two test methods are executed separately, it's as expected.
There was a problem hiding this comment.
Then, why does the async producer have the children consumer, but the synchronized producer doesn't?
There was a problem hiding this comment.
I think it's a problem with the test code, and I think I've found the solution, please take a look again, thx.
CodePrometheus
changed the title
|
|
|
Could you take a look on the go.work file under the root directory? Maybe change this file in a mistake? |
summary
Pulsar is a native go client maintained by the apache pulsar team.
test report