Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add golang 1.21, 1.22 compatibility for docker image #170

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

darknos
Copy link
Contributor

@darknos darknos commented Feb 14, 2024

Currently SkyWalking Go provided image as the base image, which currently supports the following Go versions: 1.16, 1.17, 1.18, 1.19, 1.20

but we need to support 1.21 and even 1.22

@wu-sheng wu-sheng requested a review from mrproliu February 14, 2024 12:14
@wu-sheng wu-sheng added this to the 0.4.0 milestone Feb 14, 2024
@wu-sheng wu-sheng added the enhancement New feature or request label Feb 14, 2024
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@darknos
Copy link
Contributor Author

darknos commented Feb 14, 2024

I see some checks failed but they are not connected to the PR... :(

@mrproliu
Copy link
Contributor

I have restart the CI, let's wait.

@wu-sheng wu-sheng merged commit 8d55340 into apache:main Feb 14, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants