Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9141] [RIP-75] Supports timer message on RocksDB #9142

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from

Conversation

3424672656
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9141

Brief Description

  1. Support rocksdb normal message writing and consumption
  2. Design different types of scheduled task isolation to avoid dependencies

How Did You Test This Change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimerMessageRocksDBStore 继承 TimerMessageStore 进行实现是不是在语义上更合理?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面开启rocksdb可能要考虑同时开启文件版同时支持出队,metric设计,位点维护以及不同类型定时消息隔离等设计,实现以及管理可能会更复杂

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.53786% with 241 lines in your changes missing coverage. Please review.

Project coverage is 48.16%. Comparing base (de4e48d) to head (4823690).

Files with missing lines Patch % Lines
.../store/timer/rocksdb/TimerMessageRocksDBStore.java 71.53% 74 Missing and 39 partials ⚠️
...tore/timer/rocksdb/TimerMessageRocksDBStorage.java 54.97% 69 Missing and 8 partials ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 6.25% 11 Missing and 4 partials ⚠️
...ing/protocol/header/SendMessageResponseHeader.java 28.57% 4 Missing and 1 partial ⚠️
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 5 Missing ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 37.50% 5 Missing ⚠️
...ava/org/apache/rocketmq/broker/util/HookUtils.java 0.00% 3 Missing ⚠️
...rg/apache/rocketmq/client/producer/SendResult.java 0.00% 3 Missing ⚠️
...ketmq/store/plugin/AbstractPluginMessageStore.java 0.00% 3 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 0 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9142      +/-   ##
=============================================
+ Coverage      47.99%   48.16%   +0.17%     
- Complexity     12061    12138      +77     
=============================================
  Files           1321     1324       +3     
  Lines          93024    93784     +760     
  Branches       11926    12031     +105     
=============================================
+ Hits           44643    45172     +529     
- Misses         42842    43021     +179     
- Partials        5539     5591      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RIP-75] Supports timer message on RocksDB
4 participants