DISPATCH-2235: Dump time delay before lock is acquired #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/router_core/forwarder.c
Outdated
| @@ -154,7 +154,9 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t *core, qdr_delivery_t *in | |||
| out_dlv->delivery_id = next_delivery_id(); | |||
| out_dlv->link_id = out_link->identity; | |||
| out_dlv->conn_id = out_link->conn_id; | |||
| out_dlv->dispo_lock = sys_mutex(); | |||
| char name[64]; | |||
| snprintf(name, sizeof(name), "delivery-%"PRIu32, out_dlv->delivery_id); | |||
There was a problem hiding this comment.
This snprintf is in the fast path. Is this a problem ?
There was a problem hiding this comment.
It's probably overkill, especially for this lock which is hardly used.
In fact we probably want to avoid storing the mutex name (strdup call) when we're not explicitly debugging the locks.
Update coming soon...
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
- Coverage 84.73% 84.66% -0.08%
==========================================
Files 114 114
Lines 28394 28405 +11
==========================================
- Hits 24059 24048 -11
- Misses 4335 4357 +22
Continue to review full report at Codecov.
|
ganeshmurthy
approved these changes
Aug 24, 2021
- top five total waits: $ sort --reverse --numeric --key 3 <output-file> | head -5 - top five with waits > 1000 nsc: $ sort --reverse --numeric --key 7 <output-file> | head -5 - top five maximum single-call wait times: sort --reverse --numeric --key 9 <output-file> | head -5
kgiusti
force-pushed
the
lock-contention-tracing
branch
from
7385e53 to
4569070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ sort --reverse --numeric --key 3 | head -5
$ sort --reverse --numeric --key 7 | head -5
sort --reverse --numeric --key 9 | head -5