QPID-8666: [Broker-J] Broker plugin jdbc-provider-bone replacement #238
Conversation
| "qpid.jdbcstore.bonecp.maxConnectionsPerPartition", 7, | ||
| "qpid.jdbcstore.bonecp.minConnectionsPerPartition", 6, | ||
| "qpid.jdbcstore.bonecp.partitionCount", 2); | ||
| final Map<String,Object> expectedAttributes = Map.of("connectionPoolType", "BONECP", |
There was a problem hiding this comment.
Doesnt the fact these bits of the output didnt change (now restored to their previous/original values), even though the updater is meant to be handling transition from bonecp to hikaricp pool, suggest that not everything that should be upgraded is being so?
EDIT: so this test is checking for "VirtualHostNode" context, whereas the updater is only covering "VirtualHost" context entries, which seems likely to explain things. Given both can apparently separately be using JDBC and thus pooling (even if I dont see a point for the node) it feels like both should be covered.
EDIT2: Actually, can the broker have this context config as well? to be defined in one place and inherited by the rest if they use it and not override?
There was a problem hiding this comment.
Hi Robbie,
PR-239 was created to fix those issues.
This PR is a follow-up to the PR 235 and addresses JIRA QPID-8666, adding upgrading the broker model version from 9.0 to 9.1