[improve][broker] Skip auto-creation for topics with "-partition-" suffix missing a valid partition number #23627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Nov 22, 2024
| @@ -3532,6 +3532,12 @@ private CompletableFuture<Boolean> isAllowAutoTopicCreationAsync(final TopicName | |||
| return CompletableFuture.completedFuture(true); | |||
| } | |||
|
|
|||
| // If this topic name contains "-partition--x" , not allow to be created automatically. | |||
There was a problem hiding this comment.
This would be a more accurate description:
Suggested change
| // If this topic name contains "-partition--x" , not allow to be created automatically. | |
| // Skip auto-creation for topics with "-partition-" suffix missing a valid partition number |
lhotari
changed the title
lhotari
changed the title
lhotari
changed the title
@zjxxzjwang Makes sense. Please check the review comment about the code comment and the PR title change that I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If you actively create a topic with "-partition--x" (x is an integer)(for example, "peisisten://tenant-name/ns-name/topic-name-partition--1"), the topic can be created successfully, and a node with partition 3 will be attached to the zk. But it is not a partition topic
Modifications
By modifying the isAllowAutoTopicCreationAsync logic () method, when the topic name contains "- partiton - x" (x is an integer), trigger logic returns false
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: