[feat][broker] Prevent auto-creation of topics using legacy cluster-based naming scheme #23620
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2024 11:59
…ster name in its name
…ster name in its name
lhotari
reviewed
Nov 21, 2024
| @FieldContext(category = CATEGORY_SERVER, dynamic = true, | ||
| doc = "Topic name contains cluster, not allow be created automatically." | ||
| ) | ||
| private boolean enableCreateLegacyTopic = false; |
There was a problem hiding this comment.
The config name enableCreateLegacyTopic is not optimal. Since this is related to allowAutoTopicCreation, it's better to share that prefix, for example allowAutoTopicCreationWithLegacyNamingScheme would be a more accurate config name. It should also be specified in the documentation that this config is only used when allowAutoTopicCreation=true.
lhotari
changed the title
|
Related to #23594 |
4 tasks
lhotari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Topic name rule
old version: {tenant}/{cluster}/{namespace}/{topic}
new version: {tenant}/{namespace}/{topic}
If the name of an automatically created topic contains a "/", the topic will be resolved into a four-segment format (containing a layer of cluster directories). As a result, the automatically created topic does not conform to the latest topic naming rules
Modifications
No allowto automatically create topic names that contain slashes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: