-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Reduce memory occupation of the delayed message queue #23611
Merged
thetumbled
merged 8 commits into
apache:master
from
thetumbled:Feature_ImproveInMemoryDelayedQueue
Nov 22, 2024
Merged
[improve][broker] Reduce memory occupation of the delayed message queue #23611
thetumbled
merged 8 commits into
apache:master
from
thetumbled:Feature_ImproveInMemoryDelayedQueue
Nov 22, 2024
+100
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetumbled
requested review from
lhotari,
BewareMyPower,
dao-jun,
poorbarcode,
coderzc and
mattisonchao
November 19, 2024 08:29
Good work, and I'm just wandering how much memories can we reduce? |
Updated in the PR. |
dao-jun
added
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
category/performance
Performance issues fix or improvements
labels
Nov 19, 2024
lhotari
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great improvement! Thanks for the contribution @thetumbled
lhotari
reviewed
Nov 19, 2024
...ar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Nov 19, 2024
...ar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Nov 19, 2024
...ar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
Show resolved
Hide resolved
lhotari
reviewed
Nov 19, 2024
...ar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java
Outdated
Show resolved
Hide resolved
lhotari
changed the title
[improve] [broker] reduce memory occupation of the delayed message queue
[improve][broker] Reduce memory occupation of the delayed message queue
Nov 19, 2024
dao-jun
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/performance
Performance issues fix or improvements
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Delayed queue consume a lot of memory to store the message id. We can reduce the memory occupation with new data structure simillar to #23601.
Modifications
Use new data structure to reduce memory occupation of the delayed message queue,
InMemoryDelayedDeliveryTracker
.List some experiment data with following test code:
Produce 1kw entries with 1k ledgers, with the speed of 1 msg/ms.
Original data structure: TripleLongPriorityQueue
It store the info in the direct memory, we can call
queue.bytesCapacity()
to get the size of memory it take.So, TripleLongPriorityQueue take up 240MB.
New data structure:
Long2ObjectSortedMap<Long2ObjectMap<Roaring64Bitmap>>
It store the data in heap, so we can use
jmap
to dump the memory to analyze.So, it take up only 8MB, down to only 8/240=3.33% of the original size!
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#65