[fix][broker] Immediately tombstone Deleted and Free state bundles #22743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22743 +/- ##
============================================
- Coverage 73.57% 73.20% -0.38%
+ Complexity 32624 32577 -47
============================================
Files 1877 1889 +12
Lines 139502 141433 +1931
Branches 15299 15520 +221
============================================
+ Hits 102638 103531 +893
- Misses 28908 29905 +997
- Partials 7956 7997 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Jun 6, 2024
…t channel ### Motivation NPE will happen in `UnloadManager#handleEvent` after apache#22743. It's because the `Init` state is always associated with a null `ServiceUnitStateData`. ``` java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateData.force()" because "data" is null at org.apache.pulsar.broker.loadbalance.extensions.manager.UnloadManager.handleEvent(UnloadManager.java:204) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.StateChangeListeners.lambda$notify$3(StateChangeListeners.java:74) ~[classes/:?] at java.base/java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:807) ~[?:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.StateChangeListeners.notify(StateChangeListeners.java:72) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateChannelImpl.handleInitEvent(ServiceUnitStateChannelImpl.java:902) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateChannelImpl.handle(ServiceUnitStateChannelImpl.java:715) ~[classes/:?] ``` ### Modifications In `UnloadManager#handleEvent`, assume `data` is null and call `complete` directly. Fix `UnloadManagerTest`, which passes a non-null `ServiceUnitStateData` and `Init` to `handleEvent`.
4 tasks
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f) (cherry picked from commit d982d3b)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…pache#22743) (cherry picked from commit 949260f) (cherry picked from commit d982d3b)
heesung-sn
added a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 27, 2024
…pache#22743) (cherry picked from commit 949260f) (cherry picked from commit d982d3b)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…pache#22743) (cherry picked from commit 949260f) (cherry picked from commit d982d3b) (cherry picked from commit 44f2e98)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…pache#22743) (cherry picked from commit 949260f) (cherry picked from commit d982d3b) (cherry picked from commit 44f2e98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Extensible Load Balancer cannot split bundles when a namespace is recreated. The old parent bundle before split (in the Deleted state) could block the next split operation until they are tombstoned by the leader monitor bundle cleanup job.
Extensible Load Balancer delays bundle cleanups when a namespace is deleted. Those deleted bundles are stuck in Free state until they are tombstoned by the leader monitor bundle cleanup job. Although this delayed tombstone was introduced for non-transfer unloading, these lingering bundles are not ideal when the namespace is deleted.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: heesung-sn#67