Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [test] Fix flaky test testPerTopicExpiredStat #22018

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

315157973
Copy link
Contributor

@315157973 315157973 commented Feb 4, 2024

Motivation

Large floats may fail to convert because of commas in the string
image

Modifications

Change to BigDecimal

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Technoboy- Technoboy- added this to the 3.3.0 milestone Feb 4, 2024
@Technoboy- Technoboy- changed the title [fix] [test] fix flaky test testPerTopicExpiredStat [fix] [test] Fix flaky test testPerTopicExpiredStat Feb 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7c2a75) 73.64% compared to head (5706f86) 73.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #22018   +/-   ##
=========================================
  Coverage     73.64%   73.64%           
- Complexity    32476    32497   +21     
=========================================
  Files          1863     1863           
  Lines        138816   138816           
  Branches      15217    15217           
=========================================
+ Hits         102229   102233    +4     
- Misses        28688    28696    +8     
+ Partials       7899     7887   -12     
Flag Coverage Δ
inttests 24.09% <ø> (-0.09%) ⬇️
systests 23.91% <ø> (-0.07%) ⬇️
unittests 72.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 5dfdcb7 into apache:master Feb 4, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants