Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Avoid Bookie data is never deleted #19992

Closed
wants to merge 3 commits into from

Conversation

315157973
Copy link
Contributor

@315157973 315157973 commented Apr 1, 2023

Motivation

When we clean up the data now, we first delete the index (metadata in Zookeeper), and then delete the Bookie data.
If the data deletion of Bookie fails, but the index is not there because it was deleted first,
the data of Bookie can never be deleted.

Therefore, we need to delete the data first, and then delete the index.
In this way, the entire delete operation is idempotent.
Data that is not deleted in the current cycle can be retried and deleted in the next cycle

Modifications

  1. Let the method of synchronous execution become asynchronous execution
  2. The order of deletion changes to delete the data first and then delete the index

Verifying this change

315157973#8

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@315157973 315157973 self-assigned this Apr 1, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 1, 2023
@315157973 315157973 closed this Apr 1, 2023
@315157973 315157973 reopened this Apr 1, 2023
@315157973 315157973 closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants