[fix][client] Fix NPE when acknowledging multiple messages #19874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation For a multi-topics consumer, when it acknowledges a single message, it will first find the owner topic from its message ID. If the owner topic is not subscribed by the consumer, `NotConnectedException` will be thrown. However, when it acknowledges multiple messages, if any of them is the message whose owner topic is not subscribed by the consumer, NPE will happen instead. ### Modifications When acknowledging multiple messages, ignore the message IDs whose owner topic is not subscribed. `testAckMessageInAnotherTopic` is added to cover this case. ### TODO There are many other places that do not check if `consumers.get` returns `null`, like `doReconsumeLater`, `negativeAcknowledge`, etc. This patch does not cover them.
|
@BewareMyPower Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
BewareMyPower
requested review from
lhotari,
315157973,
codelipenghui,
gaoran10,
shibd and
RobertIndie
|
I decide to ignore these invalid message IDs because in real world, it usually happens when these messages are not received by the consumer or the topic of them has been deleted and the consumer subscribes topic by a regex. |
315157973
reviewed
Mar 22, 2023
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
merlimat
approved these changes
Mar 23, 2023
315157973
approved these changes
Mar 24, 2023
AnonHxy
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a multi-topics consumer, when it acknowledges a single message, it will first find the owner topic from its message ID. If the owner topic is not subscribed by the consumer,
NotConnectedExceptionwill be thrown.However, when it acknowledges multiple messages, if any of them is the message whose owner topic is not subscribed by the consumer, NPE will happen instead.
Modifications
When acknowledging multiple messages, if there is any message ID whose owner topic is not subscribed, fail the whole acknowledgment.
testAckMessageInAnotherTopicis added to cover this case.TODO
There are many other places that do not check if
consumers.getreturnsnull, likedoReconsumeLater,negativeAcknowledge, etc. This patch does not cover them.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#22