Fix retention and backlog quota diagram #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
requested review from
lhotari,
codelipenghui,
dao-jun,
poorbarcode and
coderzc
lhotari
reviewed
Nov 6, 2024
lhotari
reviewed
Nov 6, 2024
poorbarcode
approved these changes
Nov 7, 2024
dao-jun
approved these changes
Nov 7, 2024
lhotari
reviewed
Nov 7, 2024
| @@ -37,7 +37,7 @@ Pulsar's [admin interface](admin-api-overview.md) enables you to manage both ret | |||
| By default, when a Pulsar message arrives at a broker, the message is stored until it has been acknowledged on all subscriptions, at which point it is marked for deletion. You can override this behavior and retain messages that have already been acknowledged on all subscriptions by setting a *retention policy* for all topics in a given namespace. Retention is based on both a *size limit* and a *time limit*. | |||
|
|
|||
| The diagram below illustrates the concept of message retention. | |||
|  | |||
|  | |||
There was a problem hiding this comment.
just wondering why isn't the file retention.svg simply updated? If this diagram update applies to all versions of Pulsar, there shouldn't be a need to use a new file name.
There was a problem hiding this comment.
Since I haven't modified the references for older versions, like 2.10, I've kept the original files.
There was a problem hiding this comment.
@lhotari WHYT?
Do we need to update all versions of the documentation to point to the new diagrams? This way, I can remove the original diagrams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current retention and backlog quota diagram does not match the actual implementation.
Refer to issue: apache/pulsar#22473 (comment)
Discuss thread: https://lists.apache.org/thread/g3hc3o0kmn1yvcfdj6xnlbq4vsdskx9o
Preview
Retention policy
Backlog quotas
