Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-stage] Allow filter for lookup JOIN #14523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

Customize the following 2 rules to not push down filters/transforms for lookup JOIN:

  • CoreRules.FILTER_INTO_JOIN and CoreRules.JOIN_CONDITION_PUSH: Do not push down filter to right table, but allow pushing down to left table
  • CoreRules.PROJECT_JOIN_TRANSPOSE: Disable the rule for lookup JOIN

TODO: Allow transpose to left table in CoreRules.PROJECT_JOIN_TRANSPOSE

@Jackie-Jiang Jackie-Jiang added feature multi-stage Related to the multi-stage query engine labels Nov 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.94%. Comparing base (59551e4) to head (4652829).
Report is 1385 commits behind head on master.

Files with missing lines Patch % Lines
...e/pinot/calcite/rel/rules/PinotFilterJoinRule.java 89.79% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14523      +/-   ##
============================================
+ Coverage     61.75%   63.94%   +2.19%     
- Complexity      207     1569    +1362     
============================================
  Files          2436     2675     +239     
  Lines        133233   146975   +13742     
  Branches      20636    22559    +1923     
============================================
+ Hits          82274    93981   +11707     
- Misses        44911    46063    +1152     
- Partials       6048     6931     +883     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.91% <90.74%> (+2.20%) ⬆️
java-21 63.79% <90.74%> (+2.17%) ⬆️
skip-bytebuffers-false 63.94% <90.74%> (+2.19%) ⬆️
skip-bytebuffers-true 63.77% <90.74%> (+36.04%) ⬆️
temurin 63.94% <90.74%> (+2.19%) ⬆️
unittests 63.93% <90.74%> (+2.19%) ⬆️
unittests1 55.68% <90.74%> (+8.79%) ⬆️
unittests2 34.54% <10.18%> (+6.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants