Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update H3IndexConfig.java #14522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update H3IndexConfig.java #14522

wants to merge 1 commit into from

Conversation

meshari343
Copy link

updates variable "resolution" to "resolutions" to match documentation.

@meshari343
Update H3IndexConfig.java
bc8d118 
updates variable "resolution" to "resolutions" to match documentation.
Jackie-Jiang
Jackie-Jiang requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backward incompatible, and cause existing config to fail. We should change the documentation to match the implementation instead. Which documentation are you referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meshari343 @Jackie-Jiang