Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds check if controller tmp dir exists #14503

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Harnoor7
Copy link

@Harnoor7 Harnoor7 commented Nov 20, 2024

Problem: Have observed rare exception: java.io.FileNotFoundException: /tmp/pinot-controller-tmp/fileUploadTemp/tmp-<id> (No such file or directory). Assumption is that OS might have deleted older file under tmp directory and hence deleted controllder tmp dir files.

Solution: Add validation to ensure the temp dirs are present whenever they are accessed. If absent then pinot should create them.
solution is based on : https://howtodoinjava.com/java/io/create-directories/#2-1-files-createdirectory

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant