Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark batch ingestion common code abstraction. #14415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abhioncbr
Copy link
Contributor

@abhioncbr abhioncbr commented Nov 8, 2024

As per the issue, this code abstracts the common code from the Spark 2.4 and Spark 3 modules into common code.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (59551e4) to head (121c1c8).
Report is 1378 commits behind head on master.

Files with missing lines Patch % Lines
...k/common/AbstractSparkSegmentUriPushJobRunner.java 0.00% 42 Missing ⚠️
...mon/AbstractSparkSegmentMetadataPushJobRunner.java 0.00% 36 Missing ⚠️
...k/common/AbstractSparkSegmentTarPushJobRunner.java 0.00% 36 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14415      +/-   ##
============================================
+ Coverage     61.75%   63.82%   +2.06%     
- Complexity      207     1569    +1362     
============================================
  Files          2436     2676     +240     
  Lines        133233   146898   +13665     
  Branches      20636    22528    +1892     
============================================
+ Hits          82274    93751   +11477     
- Misses        44911    46228    +1317     
- Partials       6048     6919     +871     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.78% <0.00%> (+2.07%) ⬆️
java-21 63.69% <0.00%> (+2.06%) ⬆️
skip-bytebuffers-false 63.81% <0.00%> (+2.06%) ⬆️
skip-bytebuffers-true 63.66% <0.00%> (+35.94%) ⬆️
temurin 63.82% <0.00%> (+2.06%) ⬆️
unittests 63.81% <0.00%> (+2.06%) ⬆️
unittests1 55.56% <ø> (+8.67%) ⬆️
unittests2 34.55% <0.00%> (+6.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@abhioncbr abhioncbr force-pushed the 14271-spark-batch-ingestion-refactor branch from 7a9dbcf to 121c1c8 Compare November 22, 2024 01:29
@abhioncbr abhioncbr marked this pull request as ready for review November 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants