Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing array literal usage for vector #12365

Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 4, 2024

This fixed the regression introduced by #12118 .

  • Since v1 engine support array literal, we need to support both function arrayvalueconstructor with a list of float/double literals as well as a native literal of float/double array.
  • Add new integration tests in VectorTest to cover vectorSimilarity predicate.

@xiangfu0 xiangfu0 force-pushed the fixing-array-literal-usage-for-vector branch 2 times, most recently from 727deec to 011436d Compare February 4, 2024 23:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (3cefed5) 61.72% compared to head (380ab2c) 61.54%.

❗ Current head 380ab2c differs from pull request most recent head e8e5436. Consider uploading reports for the commit e8e5436 to get more accurate results

Files Patch % Lines
...ot/common/request/context/RequestContextUtils.java 0.00% 22 Missing ⚠️
.../parsers/rewriter/PredicateComparisonRewriter.java 0.00% 5 Missing ⚠️
...org/apache/pinot/sql/parsers/CalciteSqlParser.java 0.00% 4 Missing ⚠️
...e/pinot/common/function/TransformFunctionType.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12365      +/-   ##
============================================
- Coverage     61.72%   61.54%   -0.19%     
  Complexity      207      207              
============================================
  Files          2426     2426              
  Lines        132682   132706      +24     
  Branches      20506    20519      +13     
============================================
- Hits          81901    81671     -230     
- Misses        44765    45030     +265     
+ Partials       6016     6005      -11     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 <0.01% <0.00%> (-61.67%) ⬇️
java-21 61.54% <5.88%> (-0.04%) ⬇️
skip-bytebuffers-false 27.68% <0.00%> (-33.98%) ⬇️
skip-bytebuffers-true 61.53% <5.88%> (-0.05%) ⬇️
temurin 61.54% <5.88%> (-0.19%) ⬇️
unittests 61.53% <5.88%> (-0.19%) ⬇️
unittests1 46.70% <5.88%> (-0.21%) ⬇️
unittests2 27.68% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 force-pushed the fixing-array-literal-usage-for-vector branch from 011436d to d3130cd Compare February 5, 2024 10:21
@xiangfu0 xiangfu0 force-pushed the fixing-array-literal-usage-for-vector branch from d3130cd to 3238dab Compare February 5, 2024 18:13
@xiangfu0 xiangfu0 added bugfix vector multi-stage Related to the multi-stage query engine labels Feb 5, 2024
@xiangfu0 xiangfu0 force-pushed the fixing-array-literal-usage-for-vector branch 2 times, most recently from 1d8b8fa to 380ab2c Compare February 5, 2024 18:38
@xiangfu0 xiangfu0 merged commit 480d32c into apache:master Feb 5, 2024
19 checks passed
@xiangfu0 xiangfu0 deleted the fixing-array-literal-usage-for-vector branch February 5, 2024 20:35
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR might have conflict with #12302

suyashpatel98 pushed a commit to suyashpatel98/pinot that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine vector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants