PARQUET-2371: Resolve japicmp CI failure

[amousavigourabi]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
  • https://issues.apache.org/jira/browse/PARQUET-XXX
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  No user facing changes, only resolves CI failure.

Commits

• My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

---

Japicmp failed on newly introduced classes, during review this did not cause a failure. This likely has something to do with the japicmp 0.18.1 update we pushed since then (for this, see #1176). Includes bumping japicmp to 0.18.2.
The false positives were all under the banner of CLASS_GENERIC_TEMPLATE_CHANGED. Similar problems seem to have been reported before at siom79/japicmp#345.

[amousavigourabi]

@ConeyLiu @wgtmac, this is a patch for the problems we discussed at #1141.

[ConeyLiu]

After reverting the version back to 0.16.0, the problem is gone.

[ConeyLiu]

I am fine with these changes if we want to keep the japicmp version. Or else we should revert the version change.

[wgtmac]

+1 on my side.

@Fokko @gszadovszky Do you have any comment?

[wgtmac]

I'll merge this when the CI is green to unblock CIs of other PRs.

[gszadovszky]

Sorry @wgtmac, @ConeyLiu, for the late response.
I don't think it is a bug in japicmp to fail with a new method in an existing interface. It would fail a 3rd party if it implements the interface. To avoid keep excluding files we might add a default implementation for the new methods instead, if possible.

[amousavigourabi]

@gszadovszky, the issue at hand was not that adding methods to already existing interfaces caused failures. As you noted, this would be perfectly fine and expected behaviour. Instead, japicmp failed on wholly new interfaces (see org.apache.parquet.conf.ParquetConfiguration), and new method implementations (see org.apache.parquet.hadoop.thrift.TBaseWriteSupport), under quite a vague motivation CLASS_GENERIC_TEMPLATE_CHANGED.

[gszadovszky]

Thanks for the clarification, @amousavigourabi. We cannot do anything but excluding these classes, then, I'm afraid. But the comment is a bit misleading.
Have you tried creating a bug for japicmp about it?