Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Support parsing row type json without field id #4876

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Jan 9, 2025

Purpose

As part of #4471, in order to support variant shredding, we need a way to indicate which fields require shredding. To reuse the code, we utilize the existing RowType JSON parser.

E.g. If we want to shred field v with age int and city string, we can create table like this:

CREATE TABLE T (v VARIANT)
TBLPROPERTIES (
'fields.v.shredding-schema' = '{"type":"ROW","fields":[{"name":"age","type":"INT"},{"name":"city","type":"STRING"}]}'
)

To reduce user conf, support parsing row type json without field id

Tests

API and Format

Documentation

@Zouxxyy Zouxxyy closed this Jan 10, 2025
@Zouxxyy Zouxxyy reopened this Jan 10, 2025
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit a288809 into apache:master Jan 10, 2025
12 checks passed
@Zouxxyy Zouxxyy deleted the dev/add-json branch January 10, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants