-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Support partition API #4786
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5b01f4d
[core] Support partition API: createPartition
jerry-024 541d118
support drop partition API
jerry-024 e28a515
support list partitions API
jerry-024 d0cae62
define list partitions rest api
jerry-024 35aa8ec
add ut
jerry-024 f0bddf0
add ut for drop partition
jerry-024 ed42f43
add ut for partition convert
jerry-024 1dfe8eb
format
jerry-024 427f5a7
update desc of METASTORE_PARTITIONED and update ut
jerry-024 4ec183c
update list partition api: get partition type from table
jerry-024 1d8faff
create partition return PartitionResponse and drop partition return b…
jerry-024 3e5e7ec
delete SuccessResponse
jerry-024 58a0aa3
format PartitionResponse and update open api
jerry-024 9c7139b
update partitionSpec to spec, same with PartitionResponse
jerry-024 ccd53b2
list partitions check options use table options
jerry-024 d84198d
drop partition when 404 throw exception
jerry-024 67da134
RESTCatalogTest remove inner api dependencies
jerry-024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
paimon-core/src/main/java/org/apache/paimon/rest/requests/CreatePartitionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.rest.requests; | ||
|
||
import org.apache.paimon.catalog.Identifier; | ||
import org.apache.paimon.rest.RESTRequest; | ||
|
||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonCreator; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonGetter; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
import java.util.Map; | ||
|
||
/** Request for creating partition. */ | ||
@JsonIgnoreProperties(ignoreUnknown = true) | ||
public class CreatePartitionRequest implements RESTRequest { | ||
|
||
private static final String FIELD_IDENTIFIER = "identifier"; | ||
private static final String FIELD_PARTITION_SPEC = "spec"; | ||
|
||
@JsonProperty(FIELD_IDENTIFIER) | ||
private final Identifier identifier; | ||
|
||
@JsonProperty(FIELD_PARTITION_SPEC) | ||
private final Map<String, String> partitionSpec; | ||
|
||
@JsonCreator | ||
public CreatePartitionRequest( | ||
@JsonProperty(FIELD_IDENTIFIER) Identifier identifier, | ||
@JsonProperty(FIELD_PARTITION_SPEC) Map<String, String> partitionSpec) { | ||
this.identifier = identifier; | ||
this.partitionSpec = partitionSpec; | ||
} | ||
|
||
@JsonGetter(FIELD_IDENTIFIER) | ||
public Identifier getIdentifier() { | ||
return identifier; | ||
} | ||
|
||
@JsonGetter(FIELD_PARTITION_SPEC) | ||
public Map<String, String> getPartitionSpec() { | ||
return partitionSpec; | ||
} | ||
} |
49 changes: 49 additions & 0 deletions
49
paimon-core/src/main/java/org/apache/paimon/rest/requests/DropPartitionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.rest.requests; | ||
|
||
import org.apache.paimon.rest.RESTRequest; | ||
|
||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonCreator; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonGetter; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
import org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
import java.util.Map; | ||
|
||
/** Request for deleting partition. */ | ||
@JsonIgnoreProperties(ignoreUnknown = true) | ||
public class DropPartitionRequest implements RESTRequest { | ||
|
||
private static final String FIELD_PARTITION_SPEC = "spec"; | ||
|
||
@JsonProperty(FIELD_PARTITION_SPEC) | ||
private final Map<String, String> partitionSpec; | ||
|
||
@JsonCreator | ||
public DropPartitionRequest( | ||
@JsonProperty(FIELD_PARTITION_SPEC) Map<String, String> partitionSpec) { | ||
this.partitionSpec = partitionSpec; | ||
} | ||
|
||
@JsonGetter(FIELD_PARTITION_SPEC) | ||
public Map<String, String> getPartitionSpec() { | ||
return partitionSpec; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need these tests invoking this method? Why not invoking catalog methods?