-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Using a faster deserialization method in RoaringBitmap32 #4765
Merged
JingsongLi
merged 2 commits into
apache:master
from
Tan-JiaLiang:faster_bitmap_deserialize
Dec 28, 2024
+144
−33
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
111 changes: 111 additions & 0 deletions
111
...o-benchmarks/src/test/java/org/apache/paimon/benchmark/bitmap/RoaringBitmapBenchmark.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.benchmark.bitmap; | ||
|
||
import org.apache.paimon.benchmark.Benchmark; | ||
import org.apache.paimon.fs.local.LocalFileIO; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.io.TempDir; | ||
import org.roaringbitmap.RoaringBitmap; | ||
|
||
import java.io.DataInputStream; | ||
import java.io.DataOutputStream; | ||
import java.io.File; | ||
import java.io.FileOutputStream; | ||
import java.io.IOException; | ||
import java.nio.ByteBuffer; | ||
import java.nio.file.Path; | ||
import java.util.Random; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** Benchmark for {@link RoaringBitmap}. */ | ||
public class RoaringBitmapBenchmark { | ||
|
||
public static final int ROW_COUNT = 10000000; | ||
|
||
@TempDir Path tempDir; | ||
|
||
@Test | ||
public void testDeserialize() throws Exception { | ||
Random random = new Random(); | ||
RoaringBitmap bitmap = new RoaringBitmap(); | ||
for (int i = 0; i < ROW_COUNT; i++) { | ||
if (random.nextBoolean()) { | ||
bitmap.add(i); | ||
} | ||
} | ||
|
||
File file = new File(tempDir.toFile(), "bitmap32-deserialize-benchmark"); | ||
assertThat(file.createNewFile()).isTrue(); | ||
try (FileOutputStream output = new FileOutputStream(file); | ||
DataOutputStream dos = new DataOutputStream(output)) { | ||
bitmap.serialize(dos); | ||
} | ||
|
||
Benchmark benchmark = | ||
new Benchmark("bitmap32-deserialize-benchmark", 100) | ||
.setNumWarmupIters(1) | ||
.setOutputPerIteration(true); | ||
|
||
benchmark.addCase( | ||
"deserialize(DataInput)", | ||
10, | ||
() -> { | ||
try (LocalFileIO.LocalSeekableInputStream seekableStream = | ||
new LocalFileIO.LocalSeekableInputStream(file); | ||
DataInputStream input = new DataInputStream(seekableStream)) { | ||
new RoaringBitmap().deserialize(input); | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
}); | ||
|
||
benchmark.addCase( | ||
"deserialize(DataInput, byte[])", | ||
10, | ||
() -> { | ||
try (LocalFileIO.LocalSeekableInputStream seekableStream = | ||
new LocalFileIO.LocalSeekableInputStream(file); | ||
DataInputStream input = new DataInputStream(seekableStream)) { | ||
new RoaringBitmap().deserialize(input, null); | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
}); | ||
|
||
benchmark.addCase( | ||
"deserialize(ByteBuffer)", | ||
10, | ||
() -> { | ||
try (LocalFileIO.LocalSeekableInputStream seekableStream = | ||
new LocalFileIO.LocalSeekableInputStream(file); | ||
DataInputStream input = new DataInputStream(seekableStream)) { | ||
byte[] bytes = new byte[(int) file.length()]; | ||
input.readFully(bytes); | ||
new RoaringBitmap().deserialize(ByteBuffer.wrap(bytes)); | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
}); | ||
|
||
benchmark.run(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can tested
roaringBitmap.deserialize(ByteBuffer bbf)
directly? We actually know the exact byte count of the bitmapThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean adding a benchmark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the test results, it is more optimal, and I have checked other formats, which also use it. we can just use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The premise of ByteBuffer is that we need to know the actual size of the Bitmap. This seems to require recording the actual size at serialisation time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can using it in delection vector bitmap and rbm aggregate function, but the bitmap and bsi index can not for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the bitmap index not record the byte size? Would you be willing to integrate
roaringBitmap.deserialize(ByteBuffer bbf)
into a usable place such as dv?