Add data file root location in DataFileMeta #4751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the Purpose of this PR. |
JingsongLi
reviewed
Dec 22, 2024
| @@ -131,6 +131,20 @@ public class CoreOptions implements Serializable { | |||
| .noDefaultValue() | |||
| .withDescription("The file path of this table in the filesystem."); | |||
|
|
|||
| @ExcludeFromDocumentation("Internal use only") | |||
| public static final ConfigOption<String> WAREHOUSE_ROOT_PATH = | |||
There was a problem hiding this comment.
Can you not introduce any option in this pr? Just modify data file meta.
JingsongLi
reviewed
Dec 22, 2024
| * warehouse path, when {@link CoreOptions#DATA_FILE_PATH_DIRECTORY} is set, new writen files | ||
| * will be persisted in {@link CoreOptions#DATA_FILE_PATH_DIRECTORY}. | ||
| */ | ||
| private final @Nullable String dataRootLocation; |
There was a problem hiding this comment.
We need to introduce a new version for CommitMessage and DataSplit.
You can refer to #4322
JingsongLi
reviewed
Dec 22, 2024
| * warehouse path, when {@link CoreOptions#DATA_FILE_PATH_DIRECTORY} is set, new writen files | ||
| * will be persisted in {@link CoreOptions#DATA_FILE_PATH_DIRECTORY}. | ||
| */ | ||
| private final @Nullable String dataRootLocation; |
There was a problem hiding this comment.
rename to externalPath?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation